I think this should be addressed before someone goes and takes over vB's and delete entire boards...
Anyways it's a general suggestion. Start using HTTP_GET_VARS rather than let php automatically get user input and put it into global variables.
But more importantly, ALL user input needs to be filtered through a function (with different parameters) that checks for illegal characters and strings. Kind of like Taint in perl.
Trust me, I've looked briefly at the code, and with some of those variables inserted right into sql statements, someone's gonna eventually figure out ways to retrieve passwords and delete entire boards via JOINS, compound statements, and other manipulations.
UBB's had these problems before. I hope we don't have to go through the same thing.
[Edited by Aquamarine on 10-05-2000 at 05:32 AM]
Anyways it's a general suggestion. Start using HTTP_GET_VARS rather than let php automatically get user input and put it into global variables.
But more importantly, ALL user input needs to be filtered through a function (with different parameters) that checks for illegal characters and strings. Kind of like Taint in perl.
Trust me, I've looked briefly at the code, and with some of those variables inserted right into sql statements, someone's gonna eventually figure out ways to retrieve passwords and delete entire boards via JOINS, compound statements, and other manipulations.
UBB's had these problems before. I hope we don't have to go through the same thing.
[Edited by Aquamarine on 10-05-2000 at 05:32 AM]